MarsValley/game
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Player v2 #25

Merged
sese1402 merged 1 commit from PlayerV2 into main 2022-04-06 20:58:21 +00:00
Conversation 27 Commits 1 Files changed 2 +152 -1
sese1402 commented 2022-03-29 17:01:45 +00:00 (Migrated from gitlab.com)
Copy link

As an player I want a basic cube model.

Close: marsvalley#25

As an player I want a basic cube model. Close: marsvalley#25
kerkmann commented 2022-03-29 18:35:13 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
kerkmann commented 2022-03-29 18:36:23 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 575a8d48 - trigger ci

Compare with previous version

added 1 commit <ul><li>575a8d48 - trigger ci</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=362091278&start_sha=f6330bebecc8726f2c6fdc56ff86e14912e9dc18)
kerkmann commented 2022-03-29 18:37:56 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 3344410d - fix format

Compare with previous version

added 1 commit <ul><li>3344410d - fix format</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=362092326&start_sha=575a8d482e9d884b29176eecaebc3766fc0a98a5)
codecov commented 2022-03-29 18:40:30 +00:00 (Migrated from gitlab.com)
Copy link

Codecov Report

Merging #25 (bf8eab6) into main (d5506d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #25   +/-   ##
=====================================
  Coverage   7.82%   7.82%           
=====================================
  Files          7       7           
  Lines        179     179           
=====================================
  Hits          14      14           
  Misses       165     165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5506d2...bf8eab6. Read the comment docs.

# [Codecov](https://codecov.io/gl/marsvalley/game/pull/25?src=pr&el=h1&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=MarsValley) Report > Merging [#25](https://codecov.io/gl/marsvalley/game/pull/25?src=pr&el=desc&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=MarsValley) (bf8eab6) into [main](https://codecov.io/gl/marsvalley/game/commit/d5506d2c744e843d6e577bf134bd36d9045ecc8d?el=desc&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=MarsValley) (d5506d2) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gl/marsvalley/game/pull/25/graphs/tree.svg?width=650&height=150&src=pr&token=ZQ67JU8JHC&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=MarsValley)](https://codecov.io/gl/marsvalley/game/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=MarsValley) ```diff @@ Coverage Diff @@ ## main #25 +/- ## ===================================== Coverage 7.82% 7.82% ===================================== Files 7 7 Lines 179 179 ===================================== Hits 14 14 Misses 165 165 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gl/marsvalley/game/pull/25?src=pr&el=continue&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=MarsValley). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=MarsValley) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gl/marsvalley/game/pull/25?src=pr&el=footer&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=MarsValley). Last update [d5506d2...bf8eab6](https://codecov.io/gl/marsvalley/game/pull/25?src=pr&el=lastupdated&utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=MarsValley). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=gitlab&utm_content=comment&utm_campaign=pr+comments&utm_term=MarsValley).
sese1402 commented 2022-03-31 16:46:06 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • c2536d9d - Erweiterung

Compare with previous version

added 1 commit <ul><li>c2536d9d - Erweiterung</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=364020371&start_sha=3344410dfa5cec3c76c148589651c4ed4aac4c01)
sese1402 commented 2022-03-31 16:46:28 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 871b74ff - erwiterung

Compare with previous version

added 1 commit <ul><li>871b74ff - erwiterung</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=364020638&start_sha=c2536d9df3adda578fbfb83da1cf4b36e2431f2f)
sese1402 commented 2022-03-31 17:36:45 +00:00 (Migrated from gitlab.com)
Copy link

added 3 commits

  • 7310a244 - upgrade
  • 7908d6cc - erweiterung
  • bb9931e1 - erweiterung

Compare with previous version

added 3 commits <ul><li>7310a244 - upgrade</li><li>7908d6cc - erweiterung</li><li>bb9931e1 - erweiterung</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=364054956&start_sha=871b74ff7159ad6b06ef6b6c99966be4de9b0a5a)
kerkmann commented 2022-03-31 18:08:30 +00:00 (Migrated from gitlab.com)
Copy link

added 17 commits

  • bb9931e1...f305bcf0 - 16 commits from branch main
  • 14cf4380 - Merge branch 'main' into PlayerV2

Compare with previous version

added 17 commits <ul><li>bb9931e1...f305bcf0 - 16 commits from branch <code>main</code></li><li>14cf4380 - Merge branch &#39;main&#39; into PlayerV2</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=364073475&start_sha=bb9931e12abbc21b98221ea7560f6a703fbf5309)
koopa1338 commented 2022-04-01 20:35:03 +00:00 (Migrated from gitlab.com)
Copy link

A SystemLabel is wrong here. A Player is just an component a entity can have. Systemlabels are used to label system functions that can be added to the main app with add_system() (see main.rs). With these labels system can be ordered at startup, for example to tell system with label B not to run before system with label A.

TL;DR make player a simple component with #[derive(Component, Debug)].

Also maybe a player is not only a empty component but contains some data to identify the player. I would suggest to add a field username and displayname.

A `SystemLabel` is wrong here. A `Player` is just an component a entity can have. Systemlabels are used to label system functions that can be added to the main app with `add_system()` (see `main.rs`). With these labels system can be ordered at startup, for example to tell system with label `B` not to run before system with label `A`. TL;DR make player a simple component with `#[derive(Component, Debug)]`. Also maybe a player is not only a empty component but contains some data to identify the player. I would suggest to add a field `username` and `displayname`.
koopa1338 commented 2022-04-01 20:35:03 +00:00 (Migrated from gitlab.com)
Copy link

this should not be deleted, otherwise the pipeline fails.

this should not be deleted, otherwise the pipeline fails.
koopa1338 commented 2022-04-01 20:35:03 +00:00 (Migrated from gitlab.com)
Copy link

remove parenthesis

remove parenthesis
koopa1338 commented 2022-04-01 20:35:03 +00:00 (Migrated from gitlab.com)
Copy link

because of the autodefault attribute on the main, we don't need the ..Default::default() here.
If the player is a component, we have to add it here to the cube with the insert() function.

because of the autodefault attribute on the main, we don't need the `..Default::default()` here. If the player is a component, we have to add it here to the cube with the `insert()` function.
koopa1338 commented 2022-04-01 20:36:34 +00:00 (Migrated from gitlab.com)
Copy link

requested review from @koopa1338

requested review from @koopa1338
koopa1338 commented 2022-04-01 20:36:41 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @sese1402

assigned to @sese1402
koopa1338 commented 2022-04-01 20:36:48 +00:00 (Migrated from gitlab.com)
Copy link

requested review from @kerkmann

requested review from @kerkmann
kerkmann commented 2022-04-06 19:13:08 +00:00 (Migrated from gitlab.com)
Copy link

added 3 commits

  • 14cf4380...d5506d2c - 2 commits from branch main
  • b84f4249 - Merge branch 'main' into PlayerV2

Compare with previous version

added 3 commits <ul><li>14cf4380...d5506d2c - 2 commits from branch <code>main</code></li><li>b84f4249 - Merge branch &#39;main&#39; into PlayerV2</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=368215614&start_sha=14cf4380b7b4d2fa64829a921ae8461d31221486)
kerkmann commented 2022-04-06 19:14:00 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/marsvalley/game/-/merge_requests/25/diffs?diff_id=368216107&start_sha=b84f4249edc6f278412446d8f9f91518b5b09d6a#4b569f42a6967dec04275af54f4ca9ab6a4eee64_20_20)
kerkmann commented 2022-04-06 19:14:00 +00:00 (Migrated from gitlab.com)
Copy link

added 2 commits

  • 13d05500 - fix format
  • aee0d5e9 - remove shape

Compare with previous version

added 2 commits <ul><li>13d05500 - fix format</li><li>aee0d5e9 - remove shape</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=368216107&start_sha=b84f4249edc6f278412446d8f9f91518b5b09d6a)
kerkmann commented 2022-04-06 19:15:52 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/marsvalley/game/-/merge_requests/25/diffs?diff_id=368217315&start_sha=aee0d5e97da790a86576b71b68a196af6c1e1ab7#4b569f42a6967dec04275af54f4ca9ab6a4eee64_19_19)
kerkmann commented 2022-04-06 19:15:53 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 2bf70f4c - fix main

Compare with previous version

added 1 commit <ul><li>2bf70f4c - fix main</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=368217315&start_sha=aee0d5e97da790a86576b71b68a196af6c1e1ab7)
kerkmann commented 2022-04-06 20:21:05 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 11 of the diff

changed this line in [version 11 of the diff](/marsvalley/game/-/merge_requests/25/diffs?diff_id=368256828&start_sha=2bf70f4c8b23fc77e4f32f8b9167349e411ce555#4b569f42a6967dec04275af54f4ca9ab6a4eee64_78_73)
kerkmann commented 2022-04-06 20:21:05 +00:00 (Migrated from gitlab.com)
Copy link

added 2 commits

  • f096fe41 - use capsule collider
  • e576bb07 - remove test boxed

Compare with previous version

added 2 commits <ul><li>f096fe41 - use capsule collider</li><li>e576bb07 - remove test boxed</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=368256828&start_sha=2bf70f4c8b23fc77e4f32f8b9167349e411ce555)
kerkmann commented 2022-04-06 20:24:39 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • bf8eab67 - move camera

Compare with previous version

added 1 commit <ul><li>bf8eab67 - move camera</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=368258762&start_sha=e576bb079ae0703c12b83304d9b7e762299ec642)
kerkmann commented 2022-04-06 20:44:55 +00:00 (Migrated from gitlab.com)
Copy link

added 3 commits

  • bf8eab67...165d0bb4 - 2 commits from branch main
  • 8fed5050 - Merge branch 'main' into PlayerV2

Compare with previous version

added 3 commits <ul><li>bf8eab67...165d0bb4 - 2 commits from branch <code>main</code></li><li>8fed5050 - Merge branch &#39;main&#39; into PlayerV2</li></ul> [Compare with previous version](/marsvalley/game/-/merge_requests/25/diffs?diff_id=368269363&start_sha=bf8eab678b09f924eace25e7249d7eb0923da544)
kerkmann commented 2022-04-06 20:46:01 +00:00 (Migrated from gitlab.com)
Copy link

resolved all threads

resolved all threads
kerkmann commented 2022-04-06 20:46:05 +00:00 (Migrated from gitlab.com)
Copy link

enabled an automatic merge when the pipeline for 8fed505017f55a2d74f9548ca83eaae39eb36b11 succeeds

enabled an automatic merge when the pipeline for 8fed505017f55a2d74f9548ca83eaae39eb36b11 succeeds
kerkmann commented 2022-04-06 20:58:21 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 0849d9fd6a

mentioned in commit 0849d9fd6a35000abe2decb4f15816caea44730a
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug::critical

   
bug::major

   
bug::minor

   
discussion

   
documentation

   
feature::environment

   
feature::player

   
feature::tooling

   
good first issue

   
improvement
No labels
bug::critical
bug::major
bug::minor
discussion
documentation
feature::environment
feature::player
feature::tooling
good first issue
improvement
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
MarsValley/game!25
No description provided.